Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the "Do not upload" classifier trick #643

Closed
pganssle opened this issue Aug 27, 2019 · 6 comments · Fixed by #1056
Closed

Document the "Do not upload" classifier trick #643

pganssle opened this issue Aug 27, 2019 · 6 comments · Fixed by #1056

Comments

@pganssle
Copy link
Member

In this tweet, @di mentions a trick to prevent accidentally uploading your packages to PyPI by adding a Private :: Do Not Upload classifier and in the thread @ewdurbin mentioned that he had made Private a reserved top-level classifier so the trick works reliably.

It seems like it would be a good idea to document this somewhere for easy linking. It could go into a tutorial or maybe we can add a "miscellaneous tips and tricks" section?
@ewdurbin
Copy link
Member

https://github.com/pypa/warehouse/blob/master/warehouse/templates/pages/classifiers.html which renders https://pypi.org/classifiers/ could probably also address this.

@Julian
Copy link
Contributor

Julian commented Aug 27, 2019

Should there be a License :: Closed Source for this? Having two ways to do it isn't great obviously, but possibly the advantage of using License is some tools maybe care about being able to ask about the license anyhow from classifiers, so maybe using that namespace solves both?

@pfmoore
Copy link
Member

pfmoore commented Aug 27, 2019

I may well have an open source project that I don't want to upload to PyPI (maybe because it's not yet ready for broad distribution).

@imankulov
Copy link

I came across this issue while finding a way to mark my python packages as private. Adding a cross-reference to a change in Warehouse which sort of "institutionalizes the trick": pypi/warehouse#5440

orsinium added a commit to orsinium-forks/flit that referenced this issue Feb 3, 2021
@orsinium
Allow Private :: Do Not Upload classifier.
3255c1f 
This is a special case because it is not listed in a trove classifier
but it is a way to make sure that a private package is not get uploaded
on PyPI by accident.

Implementation on PyPI side:
    pypi/warehouse#5440
Issue about officially documenting the trick:
    pypa/packaging.python.org#643
@orsinium orsinium mentioned this issue Feb 3, 2021
Merged
@NickleDave NickleDave mentioned this issue Mar 3, 2021
Open
2 tasks
@hugovk hugovk mentioned this issue Mar 6, 2022
Merged
@hugovk
Copy link
Contributor

hugovk commented Mar 6, 2022

https://github.com/pypa/warehouse/blob/master/warehouse/templates/pages/classifiers.html which renders pypi.org/classifiers could probably also address this.

Please see PR pypi/warehouse#10872 to document it on that page.

Is that sufficient or is something also needed on https://packaging.python.org?

@hugovk hugovk mentioned this issue Mar 6, 2022
Merged
@hugovk
Copy link
Contributor

hugovk commented Mar 6, 2022

Is that sufficient or is something also needed on packaging.python.org?

Please see #1056 as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document the 'Private ::' classifier prefix hugovk/packaging.python.org
6 participants
@imankulov @Julian @pfmoore @ewdurbin @hugovk @pganssle