Vendor tomli 1.2.3 in flit_core #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Dec 23, 2021
gaborbernat
approved these changes
Dec 24, 2021
Just a FYI, the vendored Looks good. :) |
Yup, definitely. The vendored version will stay there as long as it's needed for any supported Python version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the dependency cycle, and also means we don't have to special case flit_core building itself, because we can rely on having a TOML parser.
I've left a note on how it can be unbundled, but of course if people do that, they will need to deal with the dependency cycle some other way. One option would be to get flit_core and tomli installed before unbundling, another would be to make them both available without installing to use for a special bootstrapping step (like python-bootstrap does).
This should be a special case, and hopefully can go away again once there's a TOML parser in the Python standard library.
Closes #483 (I wanted to avoid the extra layers of tooling & automation that PR proposes, as this is just one package)