Reuse wheel metadata in sdist #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was not able to tell if there is a downside to using the same metadata as the wheel but a cursory investigation revealed that it's what Poetry does. setuptools omits the requirements but its PKG-INFO appears to be otherwise identical to the wheel's METADATA file. flit appears to be a bit of an outlier in creating a barebones PKG-INFO file. Closes pypa#409.
|
Seems like a good idea to me. |
|
This looks much better to me, and would fix twine warnings too. |
|
Thanks! Yes, as far as I know, PKG-INFO is the same format as METADATA. I think this separate PKG-INFO template was just a holdover from when I rather grudgingly implemented sdist generation, after initially arguing that wheels-only was fine for pure Python packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to tell if there is a downside to using the same
metadata as the wheel but a cursory investigation revealed
that it's what Poetry does. setuptools omits the requirements
but its PKG-INFO appears to be otherwise identical to the wheel's
METADATA file. flit appears to be a bit of an outlier in creating
a barebones PKG-INFO file.
Closes #409.