Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDists produces warnings with twine check #414

Closed
henryiii opened this issue Jun 12, 2021 · 2 comments · Fixed by #410
Closed

SDists produces warnings with twine check #414

henryiii opened this issue Jun 12, 2021 · 2 comments · Fixed by #410
Milestone
3.3

Comments

@henryiii
Copy link
Contributor

The SDists produce warnings like this:

$ pipx run twine check dist/cookie_flit621-0.0.1.tar.gz
Checking dist/cookie_flit621-0.0.1.tar.gz: PASSED, with warnings
  warning: `long_description_content_type` missing. defaulting to `text/x-rst`.
  warning: `long_description` missing.

I believe this would be fixed by #410.

Looking inside PKG-INFO, I see #409's issue (not exactly mangled, but has empty fields that aren't needed in newer metadata versions):

Metadata-Version: 1.1
Name: cookie_flit621
Version: 0.0.1
Summary: A great package.
Home-page: None
Author: None
Author-email: My Name <[email protected]>

The METADATA file in the wheel is fine, so I think the best fix is #410.

You can recreate this with scientific-python/cookie#21
@henryiii
Copy link
Contributor Author

henryiii commented Jun 12, 2021 •
edited
Loading

Classic configuration SDists fail the check too. Run from inside scikit-hep/cookie:

$ pipx run nox -s "dist(flit)"

or, from anywhere

$ pipx run cookiecutter gh:scikit-hep/cookie
$ # Chose flit when asked
$ cd <package directory>
$ pipx run build --sdist
$ pipx run twine check dist/*

@takluyver takluyver added this to the 3.3 milestone Jul 4, 2021
@takluyver takluyver linked a pull request Jul 4, 2021 that will close this issue
Reuse wheel metadata in sdist #410
Merged
@takluyver
Copy link
Member

Thanks @henryiii . Closing as I understand this is fixed by #410. We can reopen this - or just make another issue - if it turns out that wasn't the whole story.

@henryiii henryiii mentioned this issue Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Reuse wheel metadata in sdist layday/flit
2 participants
@takluyver @henryiii