Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rebound/reboundx to version 4.4.3/4.3.0 #5163

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

hannorein
Copy link
Contributor

@hannorein hannorein commented Nov 6, 2024

Description

Bumps the REBOUND version from 3.24.2 to 4.4.3. Also bumps REBOUNDx to 4.3.0 Fixes the compile time error mentioned in #4925.

Checklists

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hannorein! Just a minor nitpick-y suggestion.

@hannorein
Copy link
Contributor Author

It gets rid of a warning message so I thought I'll keep it for now. I'll merge these patches into the upstream in a future version of REBOUND so that we can get rid of all them.

@agriyakhetarpal
Copy link
Member

There's another error: Error: Dynamic linking error: cannot resolve symbol emscripten_sleep :(

@hannorein
Copy link
Contributor Author

I can fix that. But how come I didn't get those errors? And how can I make sure I fix them all?

@agriyakhetarpal
Copy link
Member

I can fix that. But how come I didn't get those errors? And how can I make sure I fix them all?

You could run the tests locally with pytest -svra packages/rebound/test_rebound.py – but I usually find the CI logs to be better sometimes, because from a local run I wasn't able to see that the timeout was due to a Pyodide fatal error (this one, in this case).

I'd recommend an out-of-tree build in your CI, too, if that helps and if you're interested: https://pyodide.org/en/stable/development/building-and-testing-packages.html

@hannorein
Copy link
Contributor Author

Thanks. I'm still a bit confused on how to do this properly.

Right now the tests pass locally. If the package compiles and runs fine locally, then why does it not compile in the CI?

Are the two failing CI tests main / test-core (macos-14, selenium, safari) and ci/circleci: test-core-node-nodylink failing because of something in the rebound/reboundx packages? Or is that unrelated?

@hoodmane
Copy link
Member

hoodmane commented Nov 7, 2024

Those are unrelated, don't worry about them.

@hoodmane
Copy link
Member

hoodmane commented Nov 7, 2024

CI looks good to me.

@hoodmane hoodmane merged commit 651b690 into pyodide:main Nov 7, 2024
37 of 40 checks passed
@hoodmane
Copy link
Member

hoodmane commented Nov 7, 2024

Thanks @hannorein!

@agriyakhetarpal agriyakhetarpal mentioned this pull request Nov 7, 2024
2 tasks
@hannorein hannorein deleted the rebound-4.3.3 branch November 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants