-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rebound/reboundx to version 4.4.3/4.3.0 #5163
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @hannorein! Just a minor nitpick-y suggestion.
It gets rid of a warning message so I thought I'll keep it for now. I'll merge these patches into the upstream in a future version of REBOUND so that we can get rid of all them. |
There's another error: |
I can fix that. But how come I didn't get those errors? And how can I make sure I fix them all? |
You could run the tests locally with I'd recommend an out-of-tree build in your CI, too, if that helps and if you're interested: https://pyodide.org/en/stable/development/building-and-testing-packages.html |
Thanks. I'm still a bit confused on how to do this properly. Right now the tests pass locally. If the package compiles and runs fine locally, then why does it not compile in the CI? Are the two failing CI tests |
Those are unrelated, don't worry about them. |
CI looks good to me. |
Thanks @hannorein! |
Description
Bumps the REBOUND version from 3.24.2 to 4.4.3. Also bumps REBOUNDx to 4.3.0 Fixes the compile time error mentioned in #4925.
Checklists