-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rateslib
to packages
#5146
Add rateslib
to packages
#5146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you sync your PR with the main branch? We've just deployed a fix for CI timeout.
packages/rateslib/meta.yaml
Outdated
license: Creative Commons Attribution, Non-Commercial, No-Derivatives 4.0 International Licence | ||
extra: | ||
recipe-maintainers: | ||
- attack68 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm that @attack68 would want to maintain the recipe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, attack68 is the developer of the rateslib library itself, but for now I've removed him as maintainer for this recipe. I'll provide him with instructions, and should he wish to perform an update later he can add himself at that point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, @NickAltmann!
Switch to recommended SPDX short-form identifier for license. Co-authored-by: Agriya Khetarpal <74401230 [email protected]>
The failure can be adjusted either by shortening the test or by increasing the timeout value. I guess the test is already minimal, so the latter is better. |
Thanks for the input. I'm sorry it's not clear what needs to be done here, I can't see where this timeout failure is. All I can see is a test-core failure which seems to be universal, and a build-packages-no-numpy-dependents failure which I don't understand but seems unrelated. |
The suggestion more specifically is to annotate the test with something like |
…mann/pyodide into add-rateslib-to-packages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working now, thanks, @NickAltmann!
Description
Adding meta for the rateslib package, a fixed income pricing library, see https://rateslib.readthedocs.io/en/latest/.
While the first release, 1.1, was pure python, subsequent releases have a rust extension, hence the need for a package here.
Checklists