Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rateslib to packages #5146

Merged
merged 11 commits into from
Nov 7, 2024

Conversation

NickAltmann
Copy link
Contributor

Description

Adding meta for the rateslib package, a fixed income pricing library, see https://rateslib.readthedocs.io/en/latest/.

While the first release, 1.1, was pure python, subsequent releases have a rust extension, hence the need for a package here.

Checklists

  • Add / update tests

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you sync your PR with the main branch? We've just deployed a fix for CI timeout.

packages/rateslib/meta.yaml Outdated Show resolved Hide resolved
license: Creative Commons Attribution, Non-Commercial, No-Derivatives 4.0 International Licence
extra:
recipe-maintainers:
- attack68
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please confirm that @attack68 would want to maintain the recipe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, attack68 is the developer of the rateslib library itself, but for now I've removed him as maintainer for this recipe. I'll provide him with instructions, and should he wish to perform an update later he can add himself at that point.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @NickAltmann!

packages/rateslib/meta.yaml Outdated Show resolved Hide resolved
Switch to recommended SPDX short-form identifier for license.

Co-authored-by: Agriya Khetarpal <74401230 [email protected]>
@agriyakhetarpal
Copy link
Member

The failure can be adjusted either by shortening the test or by increasing the timeout value. I guess the test is already minimal, so the latter is better.

@NickAltmann
Copy link
Contributor Author

Thanks for the input.

I'm sorry it's not clear what needs to be done here, I can't see where this timeout failure is. All I can see is a test-core failure which seems to be universal, and a build-packages-no-numpy-dependents failure which I don't understand but seems unrelated.

@hoodmane
Copy link
Member

hoodmane commented Nov 6, 2024

The suggestion more specifically is to annotate the test with something like @pytest.mark.driver_timeout(60) which would raise the timeout to 60 seconds.

Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working now, thanks, @NickAltmann!

@agriyakhetarpal agriyakhetarpal changed the title Add rateslib to packages Add rateslib to packages Nov 7, 2024
@agriyakhetarpal agriyakhetarpal merged commit 2a19f2a into pyodide:main Nov 7, 2024
40 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants