Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emscripten 3.1.52 #4399

Merged
merged 24 commits into from
Jan 23, 2024
Merged

Emscripten 3.1.52 #4399

merged 24 commits into from
Jan 23, 2024

Conversation

ryanking13
Copy link
Member

@ryanking13 ryanking13 commented Jan 21, 2024

Checklists

This was referenced Jan 21, 2024
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work @ryanking13. It's gratifying to see these updates with our emscripten patches getting dropped.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this already been unused for a while?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we didn't use it for a while. I guess it was from when we updated to CPython 3.11

#define LONG_MIN (-LONG_MAX-1)
#endif

#undef LONG_BIT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird bug, it would be interesting to investigate this further...

emsdk/patches/0001-Changes-for-JSPI.patch Outdated Show resolved Hide resolved
Comment on lines 16 to 21
# https://github.com/emscripten-core/emscripten/issues/17052
# Without this, boost outputs WASM modules not static library archives as an output.
# I don't understand why... the jam file used by boost is quite hard to understand.
printf "using clang : emscripten : emcc : <archiver>emar <ranlib>emranlib <linker>emlink ;" | tee -a ./project-config.jam

./b2 variant=release toolset=clang-emscripten link=static threading=single \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanking13 ryanking13 merged commit a14d34f into pyodide:main Jan 23, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants