Add tests #9981
Merged
Add tests #9981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9981 /- ##
=======================================
Coverage 95.80% 95.80%
=======================================
Files 174 174
Lines 18946 18946
=======================================
Hits 18152 18152
Misses 794 794 |
Pierre-Sassoulas
added
the
Maintenance
jacobtylerwalls
previously approved these changes
Sep 29, 2024
|
I can fix up the commits, but it will require rerunning all the tests to update their output. Could you merge #9982 first so I can run Pytest? |
nickdrozd
force-pushed
the
add-tests
branch
from
5f57434
to
f5ea1bd
Compare
Pierre-Sassoulas
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Add tests for open issues #9668, #9815, #8893, #9941, #9642, and #9689. Some are false negatives and some are false positives.