-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump astroid to 3.3.4 #9951
Bump astroid to 3.3.4 #9951
Conversation
(cherry picked from commit 82c133d)
(cherry picked from commit 82c133d) Co-authored-by: Jacob Walls <[email protected]>
Ignoring the sentry |
Looks like the common pattern is that the errors are f-string related. Perhaps a regression related to the JoinStr changes that happened in astroid pylint-dev/astroid@3dbf139 |
Sorry may be the attempted fix for JoinStr in 3.3.4 version is causing other issues. |
I think the 3.3.4 JoinedStr fix is causing desired changes in the primer baseline, see #9963. |
You are right. Almost all of these are the result of the f-string inference working correctly. One message is a head scratcher. The following looks like a new false postive, doesn't it?
On a positive note, I don't think there are any known primer issues anymore!! |
Well, pylint/pylint/checkers/typecheck.py Lines 1370 to 1372 in 8630cfd
... but here we can rule out None because we're under an implicit boolean check. If the check were
Thank you, this was a huge contribution on your part! No more apologies to contributors for distracting primer feedback! And of course fewer end-user headaches! |
Yeah, thank you for your work on primers @akamat10 ! |
Sounds good. Thanks for the explanation @jacobtylerwalls |
Closes #9947