Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false negative for duplicate-argument-name #9670

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Fix a false negative for duplicate-argument-name #9670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift click to select a range
1ad19d4
Fix a false negative for ``duplicate-argument-name`` by including ``p…
mbyrnepr2 May 22, 2024
156212b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 22, 2024
a4d1036
Update functional test output by adding quotes to the duplicate argument
mbyrnepr2 May 22, 2024
9fd8636
Regenerate the docs.
mbyrnepr2 May 22, 2024
a2700ff
Update pylint/checkers/base/basic_error_checker.py
mbyrnepr2 May 22, 2024
cbd20f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 22, 2024
aab51bb
Refactor the tests for readability.
mbyrnepr2 May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Refactor the tests for readability.
  • Loading branch information
@mbyrnepr2
mbyrnepr2 committed May 22, 2024
commit aab51bb3ea2277e94ac0bf7b2200dddac49cbea0
11 changes: 8 additions & 3 deletions tests/functional/d/duplicate/duplicate_argument_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 1,6 @@
"""Check for duplicate function arguments."""

# pylint: disable=missing-docstring, line-too-long
# pylint: disable=missing-docstring, line-too-long, unused-argument


def foo1(_, _): # [duplicate-argument-name]
Expand All @@ -18,6 18,11 @@ def foo4(_, *, _): # [duplicate-argument-name]
def foo5(_, *_, _=3): # [duplicate-argument-name, duplicate-argument-name]
...

# 1: [duplicate-argument-name, duplicate-argument-name, duplicate-argument-name, duplicate-argument-name]
def foo6(_, /, _, *_, _="_", **_):
def foo6(a, *a): # [duplicate-argument-name]
...

def foo7(a, /, a): # [duplicate-argument-name]
...

def foo8(a, **a): # [duplicate-argument-name]
...
7 changes: 3 additions & 4 deletions tests/functional/d/duplicate/duplicate_argument_name.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 4,6 @@ duplicate-argument-name:12:12:12:13:foo3:Duplicate argument name '_' in function
duplicate-argument-name:15:15:15:16:foo4:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:18:13:18:14:foo5:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:18:16:18:17:foo5:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:22:15:22:16:foo6:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:22:19:22:20:foo6:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:22:22:22:23:foo6:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:22:31:22:32:foo6:Duplicate argument name '_' in function definition:HIGH
duplicate-argument-name:21:13:21:14:foo6:Duplicate argument name 'a' in function definition:HIGH
duplicate-argument-name:24:15:24:16:foo7:Duplicate argument name 'a' in function definition:HIGH
duplicate-argument-name:27:14:27:15:foo8:Duplicate argument name 'a' in function definition:HIGH
Loading