Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport maintenance/3.2.x] [trailing-comma-tuple] Fix enabling with message control locally when disabled for the file #9649

Merged
merged 1 commit into from
May 18, 2024
Merged

[Backport maintenance/3.2.x] [trailing-comma-tuple] Fix enabling with message control locally when disabled for the file #9649

merged 1 commit into from
May 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport 96fad05 from #9609.

@jacobtylerwalls jacobtylerwalls added this to the 3.2.1 milestone May 18, 2024
@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) May 18, 2024 15:16
@codecov Codecov
Copy link

codecov bot commented May 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (1498675) to head (21f6635).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           maintenance/3.2.x    #9649    /-   ##
==================================================
  Coverage              95.86%   95.86%           
==================================================
  Files                    174      174           
  Lines                  18904    18907     3     
==================================================
  Hits                   18122    18125     3     
  Misses                   782      782
Files Coverage Δ
pylint/checkers/refactoring/refactoring_checker.py 98.27% <100.00%> ( <0.01%) ⬆️
pylint/lint/message_state_handler.py 96.48% <ø> (ø)

@Pierre-Sassoulas @jacobtylerwalls
[trailing-comma-tuple] Fix enabling with message control locally when…
21f6635 
… disabled for the file (#9609)

* [trailing-comma-tuple] Set the confidence to HIGH

* [trailing-comma-tuple] Properly emit when disabled globally and enabled locally

* [trailing-comma-tuple] Handle case with space between 'enable' and '='

(cherry picked from commit 96fad05)
@jacobtylerwalls jacobtylerwalls force-pushed the backport-9609-to-maintenance/3.2.x branch from 0a45f5d to 21f6635 Compare May 18, 2024 15:36
@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) May 18, 2024 15:36
@jacobtylerwalls jacobtylerwalls merged commit 926547b into maintenance/3.2.x May 18, 2024
24 checks passed
@jacobtylerwalls jacobtylerwalls deleted the backport-9609-to-maintenance/3.2.x branch May 18, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

Assignees
No one assigned
Labels
Bug 🪲
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobtylerwalls @Pierre-Sassoulas