Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primer - remove .git suffix from github URL. #8676

Merged
merged 1 commit into from
May 11, 2023
Merged

Primer - remove .git suffix from github URL. #8676

merged 1 commit into from
May 11, 2023

Conversation

mbyrnepr2
Copy link
Member

@mbyrnepr2 mbyrnepr2 commented May 11, 2023 •
edited
Loading

Type of Changes

Type
✓ 🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Description

There is an AssertionError in the CI primer workflow because one of the package URLs has .git at the end.

Traceback (most recent call last):
[47](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:48)
  File "/home/runner/work/pylint/pylint/tests/primer/__main__.py", line 17, in <module>
[48](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:49)
    primer.run()
[49](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:50)
  File "/home/runner/work/pylint/pylint/pylint/testutils/_primer/primer.py", line 93, in run
[50](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:51)
    self.command.run()
[51](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:52)
  File "/home/runner/work/pylint/pylint/pylint/testutils/_primer/primer_compare_command.py", line 26, in run
[52](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:53)
    comment = self._create_comment(missing_messages_data, new_messages_data)
[53](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:54)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[54](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:55)
  File "/home/runner/work/pylint/pylint/pylint/testutils/_primer/primer_compare_command.py", line 63, in _create_comment
[55](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:56)
    comment  = self._create_comment_for_package(
[56](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:57)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[57](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:58)
  File "/home/runner/work/pylint/pylint/pylint/testutils/_primer/primer_compare_command.py", line 128, in _create_comment_for_package
[58](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:59)
    assert not self.packages[package].url.endswith(
[59](https://github.com/pylint-dev/pylint/actions/runs/4945892156/jobs/8843239956#step:9:60)
AssertionError: You don't need the .git at the end of the github url.

@mbyrnepr2 mbyrnepr2 added Skip news 🔇 This change does not require a changelog entry primer labels May 11, 2023
@mbyrnepr2 mbyrnepr2 mentioned this pull request May 11, 2023
Merged
@mbyrnepr2 mbyrnepr2 added the Maintenance Discussion or action around maintaining pylint or the dev workflow label May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #8676 (41e9a93) into main (f4bd67b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8676    /-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files         172      172           
  Lines       18301    18301           
=======================================
  Hits        17534    17534           
  Misses        767      767

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0d878dd into pylint-dev:main May 11, 2023
@mbyrnepr2 mbyrnepr2 deleted the primer_remove_dot_git_suffix branch May 11, 2023 11:26
@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request May 12, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow primer Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbyrnepr2 @Pierre-Sassoulas