Fix false negative for no-value-for-parameter
#8575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyrnepr2
changed the title
no-value-for-parameter when a function, whβ¦no-value-for-parameter
mbyrnepr2
changed the title
no-value-for-parameterno-value-for-parameter
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8575 /- ##
=======================================
Coverage 95.91% 95.91%
=======================================
Files 174 174
Lines 18371 18373 2
=======================================
Hits 17620 17622 2
Misses 751 751
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 5436976 |
β¦ose signature contains both a positional-only parameter ``name`` and also ``*kwargs``, is called with a keyword-argument for ``name``. Closes #8559
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 6af34e4 |
jacobtylerwalls
approved these changes
Apr 15, 2023
| @@ -0,0 1 @@ | |||
| no-value-for-parameter:11:0:11:16::No value for argument 'param1' in function call:UNDEFINED | |||
There was a problem hiding this comment.
In a follow-up we could add the confidence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix false negative for
no-value-for-parameterwhen a function, whose signature contains both a positional-only parameternameand also*kwargs, is called with a keyword-argument forname.Closes #8559