Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use removed function from astroid #8525

Merged
merged 2 commits into from
Apr 1, 2023
Merged

Don't use removed function from astroid #8525

merged 2 commits into from
Apr 1, 2023

Conversation

DanielNoord
Copy link
Collaborator

Fixes incompatibility with current main of astroid.

@DanielNoord DanielNoord added Maintenance Discussion or action around maintaining pylint or the dev workflow backport maintenance/3.3.x labels Apr 1, 2023
@DanielNoord DanielNoord added this to the 2.17.2 milestone Apr 1, 2023
@DanielNoord DanielNoord added the Skip news 🔇 This change does not require a changelog entry label Apr 1, 2023
jacobtylerwalls
jacobtylerwalls previously approved these changes Apr 1, 2023
View reviewed changes
@jacobtylerwalls jacobtylerwalls dismissed stale reviews from Pierre-Sassoulas and themself via 533e980 April 1, 2023 21:00
@github-actions

This comment has been minimized.

Sign in to view
@DanielNoord
Copy link
Collaborator Author

Thanks @jacobtylerwalls

@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #8525 (533e980) into main (13e55d3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8525    /-   ##
=======================================
  Coverage   95.90%   95.90%           
=======================================
  Files         174      174           
  Lines       18357    18360     3     
=======================================
  Hits        17605    17608     3     
  Misses        752      752
Impacted Files Coverage Δ
pylint/checkers/imports.py 94.38% <100.00%> ( 0.03%) ⬆️

jacobtylerwalls
jacobtylerwalls approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jacobtylerwalls jacobtylerwalls enabled auto-merge (squash) April 1, 2023 21:09
@jacobtylerwalls jacobtylerwalls merged commit f7bd676 into pylint-dev:main Apr 1, 2023
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Apr 1, 2023
@DanielNoord @github-actions
Don't use removed function from astroid (#8525)
32f0383 
(cherry picked from commit f7bd676)
@DanielNoord DanielNoord deleted the cached branch April 1, 2023 21:18
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2023

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 533e980

Pierre-Sassoulas pushed a commit that referenced this pull request Apr 2, 2023
@github-actions @DanielNoord
Don't use removed function from astroid (#8525) (#8526)
538c41b 
(cherry picked from commit f7bd676)

Co-authored-by: Daniël van Noord <13665637 [email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtylerwalls jacobtylerwalls jacobtylerwalls approved these changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

Assignees
No one assigned
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Milestone
2.17.2
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @Pierre-Sassoulas @jacobtylerwalls