Remove deprecated functions and classes #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielNoord
added
the
Maintenance
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8409 /- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 176 175 -1
Lines 18504 18465 -39
=======================================
- Hits 17705 17668 -37
Misses 799 797 -2
|
Pierre-Sassoulas
requested changes
Mar 8, 2023
doc/whatsnew/fragments/8409.breaking
Outdated
| A number of old utility functions and classes have been removed. | ||
| These are ``MapReduceMixin``, ``is_inside_lambda``, ``check_messages``, | ||
| ``is_class_subscriptable_pep585_with_postponed_evaluation_enabled``, | ||
| ``get_python_paht``, ``fix_import_path`` and ``get_global_option``. |
There was a problem hiding this comment.
Suggested change
| ``get_python_paht``, ``fix_import_path`` and ``get_global_option``. | |
| ``get_python_path``, ``fix_import_path`` and ``get_global_option``. |
I was wondering about that. It feels as if the changelog can become very long. Shouldn't we just refer to the code and let the old |
|
Yeah it's going to be long but it's the place where people are going to look first when something break, so it needs to explain what to do imo (also if someone is taking care of the deprecation warnings they won't need it). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
force-pushed
the
deprecate
branch
from
b4e6e9d
to
d7db439
Compare
Pierre-Sassoulas
previously approved these changes
Mar 9, 2023
|
@Pierre-Sassoulas LGTM! |
|
But docs fail :( |
This comment has been minimized.
This comment has been minimized.
Pierre-Sassoulas
approved these changes
Mar 9, 2023
|
π€ Effect of this PR on checked open source code: π€ Effect on django:
Effect on music21:
The following messages are no longer emitted:
Effect on pandas:
The following messages are no longer emitted:
This comment was generated for commit 3b4d040 |
Merged
Merged
toofar
added a commit
to qutebrowser/qutebrowser
that referenced
this pull request
Oct 11, 2023
Changelog: https://pylint.pycqa.org/en/latest/whatsnew/3/3.0/index.html#summary-release-highlights remove `__implements__`: That attribute is apparently from a rejected PEP. They say to inherit from BaseChecker, which we are already doing. pylint-dev/pylint#8404 check_messages -> only_required_for_messages: Seems straightforward instructions. I haven't actually tested it. pylint-dev/pylint#8409 remove emptystring extension: Looks like this has been replaced by https://pylint.readthedocs.io/en/stable/user_guide/messages/convention/use-implicit-booleaness-not-comparison-to-string.html Which is disabled by default but we have `enable=ALL`, so I guess that means we indeed have it enabled. And update changelog URLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
We're getting there.