Codecov Report

Merging #8223 (64e68b5) into main (4cbabc9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8223    /-   ##
=======================================
  Coverage   95.45%   95.45%           
=======================================
  Files         177      177           
  Lines       18635    18661    26     
=======================================
  Hits        17788    17813    25     
- Misses        847      848     1     

Maybe we should keep what we had because it's a kind of breaking change. I'm so not the person to tell you if the default color palette looks good or not... But now that it can be user defined then it's fine, user can change it to taste :)

By that same logic, anyone who just has to have alice blue and antique white is also free to specify them! But somehow I have the feeling that few will actually choose those colors 😆

You'd be surprised, people get accustomed to thing and if it changes there's always someone complaining. https://imgs.xkcd.com/comics/workflow.png

I don't have a strong opinion on changing the default colors.
We can leave them as they are, and change them in 3.0.

I will leave it as it is currently (i.e. stick with the previous default colors and leave the TODO to switch for 3.0) and will take care of the spelling errors this evening.
Trying to install enchant yesterday resulted in a downwards spiral that made me update macOS. Sometimes you gotta love being a developer... 😅

Trying to install enchant yesterday resulted in a downwards spiral that made me update macOS. Sometimes you gotta love being a developer...

https://www.youtube.com/watch?v=AbSehcT19u0

Sure, the default colors could be changed later, as part of the wider push for sane defaults. But they really should be changed. It's not just my opinion that default colors are bad; the SO post that prompted the color issue specifically mentions wanting to change the "faint blue color" to a darker one.

And it's not just about opinions. The new proposed colors are objectively better in terms of accessibility than the current defaults. Actually, the ugliness and the inaccessibility have the same root cause, which is that alice blue and antique white are both difficult to distinguish from each other and difficult to distinguish from a white background.

As an example, here is a package diagram generated by Pyreverse with the current colors:

As a 3.0 version is probably not far away from what I understood (#7607 (comment)), let's not do a breaking change in 2.17 and just do it with the next major version.

Also as a side note, pyenchant with Apple Silicon is just a big oof. You need to install both Python and enchant as x86_64 version (which is possible by following their docs; you will afterwards find yourself impossible to run pylint ever again with the native arm64 version of Python, as it will always try to load the incompatible x86 binaries.

So I'll still have to rely on the CI for catching spelling problems. 😐

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 64e68b5