Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a false positive for redefined-variable-type when async methods are present. #8123

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix a false positive for redefined-variable-type when async methods are present. #8123

merged 1 commit into from
Jan 28, 2023

Conversation

mbyrnepr2
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix
✨ New feature
πŸ”¨ Refactoring
πŸ“œ Docs

Description

Closes #8120

@mbyrnepr2 mbyrnepr2 added False Positive 🦟 A message is emitted but nothing is wrong with the code Bug πŸͺ² labels Jan 27, 2023
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's pretty clean !

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.16.0 milestone Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #8123 (f93d68d) into main (b87cf16) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8123       /-   ##
==========================================
  Coverage   95.43%   95.53%    0.09%     
==========================================
  Files         176      177        1     
  Lines       18545    18600       55     
==========================================
  Hits        17698    17769       71     
  Misses        847      831      -16
Impacted Files Coverage Ξ”
pylint/extensions/redefined_variable_type.py 96.07% <100.00%> (ΓΈ)
pylint/checkers/base/basic_error_checker.py 95.51% <0.00%> (-0.04%) ⬇️
pylint/checkers/variables.py 97.38% <0.00%> (ΓΈ)
pylint/checkers/exceptions.py 97.85% <0.00%> (ΓΈ)
pylint/checkers/method_args.py 100.00% <0.00%> (ΓΈ)
...sions/consider_refactoring_into_while_condition.py 100.00% <0.00%> (ΓΈ)
pylint/checkers/base/name_checker/checker.py 99.23% <0.00%> ( <0.01%) ⬆️
pylint/checkers/stdlib.py 96.70% <0.00%> ( 0.01%) ⬆️
pylint/checkers/base/basic_checker.py 97.90% <0.00%> ( 0.02%) ⬆️
pylint/checkers/typecheck.py 96.33% <0.00%> ( 0.09%) ⬆️
... and 4 more

@github-actions
Copy link
Contributor

πŸ€– According to the primer, this change has no effect on the checked open source code. πŸ€–πŸŽ‰

This comment was generated for commit f93d68d

@mbyrnepr2 mbyrnepr2 merged commit 660405e into pylint-dev:main Jan 28, 2023
@mbyrnepr2 mbyrnepr2 deleted the 8120_redefined_variable_type branch January 28, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Bug πŸͺ² False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.16.0
Development

Successfully merging this pull request may close these issues.

R0204: Redefinition of <name> type - False positive on async functions.
2 participants
@mbyrnepr2 @Pierre-Sassoulas