Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation examples for too-many-instance-attributes #7069

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

julthep
Copy link
Contributor

@julthep julthep commented Jun 26, 2022

Co-authored-by: Vladyslav Krylasov [email protected]

Type of Changes

Type
📜 Docs

Description

Add documentation examples for too-many-instance-attributes

Refs #5953

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the refactor message examples needs to actually suggest a refactor and for this we need something understandable.

doc/data/messages/t/too-many-instance-attributes/bad.py Outdated Show resolved Hide resolved
doc/data/messages/t/too-many-instance-attributes/good.py Outdated Show resolved Hide resolved
@DanielNoord
Copy link
Collaborator

@julthep Could you rebase this PR or pull main? It should fix the issue we're seeing here!

@DanielNoord DanielNoord merged commit c0710af into pylint-dev:main Jul 7, 2022
@julthep julthep deleted the too-many-instance-attributes branch July 8, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants