Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation examples for non-parent-init-called #7047

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

julthep
Copy link
Contributor

@julthep julthep commented Jun 25, 2022

Co-authored-by: Vladyslav Krylasov [email protected]

Type of Changes

Type
📜 Docs

Description

Add documentation examples for non-parent-init-called

Refs #5953

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little nitpick because the base class can't be the more specialized one, Shape must have a lot of behavior that are specific to it and Square is "simple" with only one attribute.

doc/data/messages/n/non-parent-init-called/bad.py Outdated Show resolved Hide resolved
doc/data/messages/n/non-parent-init-called/good.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas merged commit e77b45b into pylint-dev:main Jun 25, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the work you're doing right now to document pylint @julthep , impressive !

@julthep julthep deleted the non-parent-init-called branch June 25, 2022 12:27
@julthep
Copy link
Contributor Author

julthep commented Jun 25, 2022

Thank you for all the work you're doing right now to document pylint @julthep , impressive !

You're welcome. Actually, not as impressive as all of you folks are doing wonderful work without breaks for this awesome project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants