Run linking and diadef handling with patched sys.path
#6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudeNr33
added
pyreverse
Pull Request Test Coverage Report for Build 2327649764
💛 - Coveralls |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Everything until (and including)
handler.get_diadefsshould happen in thewith fix_import_path(args)block:operations that include anything related to inference may try to import modules.
As my original goal was to enable testing the fix of #6612, I included the other necessary change for that:
Do not treat modules with a leading underscore in the functional tests folder as standalone test files.
And I noticed that I didn't write tests for the
pyreversetestutils so far, so added some basic tests for that as well.