Fix handling of default value for extend action in Python 3.7 #6450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2215610003
💛 - Coveralls |
DanielNoord
approved these changes
Apr 24, 2022
|
Thanks @DudeNr33! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and preferred name in
script/.contributors_aliases.jsonType of Changes
Description
Using
default=[]in Python 3.7 has the effect that values passed in for this parameter will be stored in the default list object. In subsequent runs (in the same process), the default value is wrongly prepopulated.Python 3.8 and above handle this situation better, but as we have to support Python 3.7 this fix is necessary.
Ref: #6449 (comment)
This change should be covered e.g. by
tests/pyreverse/test_main.py::test_command_line_arguments_defaults[classes-expected_default1].