bad-whitespace checking around dotted type hint #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you! |
rogalski
approved these changes
Apr 18, 2017
petrpulc
approved these changes
Apr 21, 2017
| @@ -631,6 631,8 @@ def _has_valid_type_annotation(self, tokens, i): | |||
| elif token[1] == ',': | |||
| if not bracket_level: | |||
| return False | |||
| elif token[1] == '.': | |||
| continue | |||
There was a problem hiding this comment.
Well, yes, this is one possible solution. Thanks for a fix 👍
mbdevpl
pushed a commit
to mbdevpl/pylint
that referenced
this pull request
Sep 27, 2017
PCManticore
pushed a commit
that referenced
this pull request
Sep 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1429
Fixes / new features