Codecov Report

Merging #47 (e6b3f97) into main (40a7b85) will increase coverage by 0.57%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #47       /-   ##
==========================================
  Coverage   48.08%   48.66%    0.57%     
==========================================
  Files          19       19              
  Lines        1046     1046              
==========================================
  Hits          503      509        6     
  Misses        543      537       -6     

I'm not sure about going through tracing for this, though. On Windows, It's really common for DLL loading to pick up an onnxruntime DLL in System32 that is many versions behind. If a user doesn't have tracing_subscriber set up (which is required to receive tracing messages), they wouldn't get any indication of failure other than cargo's obscure message of process didn't exit successfully: ... (exit code: 0xc000007b)

Thoughts about panicking if the minor version is lower, but tracing::warning if it's higher? Something like

    let minor_version = version_string.split('.').nth(1).map(|x| x.parse::<u32>().unwrap_or(0)).unwrap_or(0);
    if minor_version < 14 {
        panic!("ort 1.14 is not compatible...");
    } else if minor_version > 14 {
        warn!("ort 1.14 may have compatibility issues...");
    }

That would be fantastic thanks, see updated code

@sudo-carson any plans to support onnxruntime v1.15?

@sudo-carson any plans to support onnxruntime v1.15?

Very soon, yes.