Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python the 13th #4270

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Python the 13th #4270

merged 5 commits into from
Jun 20, 2024

Conversation

illume
Copy link
Member

@illume illume commented Jun 19, 2024

Continued on from #4269 by @hroncok

  • Inline _PyArg_NoKeywords from Python 3.13 in case it is missing
  • math: Fix _PyArg_NoKeywords ifdef for python 3.13

@@ -4413,6 4413,37 @@ com_descr_get(PyObject *self, PyObject *obj, PyObject *type)
return PyMethod_New(com->obj_callable, obj);
}

/* python > 3.12 */
#if PY_VERSION_HEX > 0x030C0000
#ifndef _PyArg_NoKeywords
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this #ifndef is no longer necessary. The idea was that it would prevent the code from existing on Python < 3.13, but apparently, it did not work properly everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. It can't hurt I don't think.

@illume illume merged commit 227ef6a into main Jun 20, 2024
18 checks passed
@illume illume deleted the python3.13 branch June 20, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants