added drop down using AccordionWidget #336
Conversation
| itemList = [] | ||
| page1 = [] | ||
| for item in self._initial_conditions_text_widgets: | ||
| itemList.append(widgets.Text(description=item.name)) |
There was a problem hiding this comment.
we need to add value here. i try to find value using dir(symbol) but i didn't find this.
widgets.Text(description=item.name, value = ***)
There was a problem hiding this comment.
@moorepants how to get symbol value . you have any idea ?
There was a problem hiding this comment.
The initial condition symbol and value are stored in self._system.initial_conditions.
|
Do you have an example that illustrates this change? |
|
example ---> |
|
It looks like you implement an accordion view but only use a single page which doesn't help with the original issue. Also please reference the issue number in this PR.
If you're going to go with accordion view, I think it would look better to always use it and just add pages as necessary. |
|
@oliverlee in this case scroller is best option. i will try to add scroller using |
|
The above looks pretty good to me. You just need to make a box for the initial conditions too. |
|
|
|
I think an accordion for each of the initial conditions and the constants is preferable. Some systems have long lists of states too. |
|
@moorepants How to get |
|
I don't understand what you are asking. |
| _itemList = [] | ||
| _initial_item = [] | ||
| for item in self._initial_conditions_text_widgets: | ||
| _itemList.append(widgets.Text(description=item.name)) |
There was a problem hiding this comment.
Sorry for delay, We need to add value property here but i don't know how to get value of item.
issue #205
commit message.
nosetests) and on Travis CI.format.)
docsdirectory)
pylint, to check your code)
Notes.
follow deprecation cycles.)