Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing issue with field_validator-decorated methods #9914

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Jul 17, 2024

Closes #9870.

We should add the snippet from that issue to the mypy tests for this before merging.

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label Jul 17, 2024
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024

Deploying pydantic-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 605a87c
Status: ✅  Deploy successful!
Preview URL: https://e9ef30d3.pydantic-docs.pages.dev
Branch Preview URL: https://dmontagu-9870.pydantic-docs.pages.dev

View logs

Copy link

codspeed-hq bot commented Jul 17, 2024

CodSpeed Performance Report

Merging #9914 will not alter performance

Comparing dmontagu/9870 (605a87c) with main (fc25478)

Summary

✅ 13 untouched benchmarks

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectacular work @dmontagu!

@sydney-runkle sydney-runkle merged commit 520d52e into main Jul 18, 2024
61 checks passed
@sydney-runkle sydney-runkle deleted the dmontagu/9870 branch July 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes-fix Used for bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy throws Too few arguments for "__call__" error on field_validator
3 participants