Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with config behavior being baked into the ref schema for enums #8920

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix issue with config behavior being baked into the ref schema for enums #8920

merged 2 commits into from
Mar 1, 2024

Conversation

dmontagu
Copy link
Contributor

@dmontagu dmontagu commented Feb 29, 2024 •
edited by pydantic-hooky bot
Loading

Fix #8858

Selected Reviewer: @hramezani

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 29, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d4f9ae4
Status: ✅  Deploy successful!
Preview URL: https://a67bf2f2.pydantic-docs2.pages.dev
Branch Preview URL: https://fix-use-enum-values-config-r.pydantic-docs2.pages.dev

View logs

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 29, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8920 will not alter performance

Comparing fix-use-enum-values-config-ref (d4f9ae4) with main (0eb31fc)

Summary

✅ 10 untouched benchmarks

@dmontagu dmontagu added the relnotes-fix Used for bugfixes. label Feb 29, 2024
@dmontagu dmontagu changed the title Fix issue with config behavior being baked into a ref schema Fix issue with config behavior being baked into the ref schema for enums Feb 29, 2024
@sydney-runkle sydney-runkle mentioned this pull request Feb 29, 2024
Closed
1 task
@sydney-runkle
Copy link
Member

Please review

@sydney-runkle sydney-runkle merged commit 2ff76ab into main Mar 1, 2024
55 checks passed
@sydney-runkle sydney-runkle deleted the fix-use-enum-values-config-ref branch March 1, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hramezani hramezani hramezani approved these changes

Assignees

@hramezani hramezani

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use_enum_values=True has no effect if another model with the same enum has use_enum_values=False
3 participants
@dmontagu @sydney-runkle @hramezani