Add a test demonstrating why we don't reset the parent namespace in create_model
#8376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmontagu
commented
Dec 15, 2023
| @@ -133,6 133,7 @@ class BaseModel(metaclass=_model_construction.ModelMetaclass): | |||
| # pydantic._internal._generate_schema.GenerateSchema.model_schema to work for a plain BaseModel annotation | |||
| model_fields = {} | |||
| __pydantic_decorators__ = _decorators.DecoratorInfos() | |||
| __pydantic_parent_namespace__ = None | |||
There was a problem hiding this comment.
I noticed this attribute could fail to be defined in some places where it was accessed. (In particular, this was causing the added test to fail.)
Explicitly setting it to None here fixed that.
Deploying with
|
| Latest commit: |
465e884
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b4b137cd.pydantic-docs2.pages.dev |
| Branch Preview URL: | https://dmontagu-create-model-no-res.pydantic-docs2.pages.dev |
CodSpeed Performance ReportMerging #8376 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test showing why the line of code removed in #8011 was there