Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mesonbuild #420

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Mesonbuild #420

wants to merge 18 commits into from

Conversation

lukeolson
Copy link
Member

  • move to a meson-based build
  • remove setuptools
  • update install instructions (for editable)

@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (c45e9af) to head (2cebb3f).
Report is 3 commits behind head on main.

Files Patch % Lines
pyamg/_tools/_tester.py 0.00% 46 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #420        /-   ##
==========================================
- Coverage   82.25%   0.00%   -82.26%     
==========================================
  Files          83      84         1     
  Lines       12464   12616       152     
  Branches     1875       0     -1875     
==========================================
- Hits        10252       0    -10252     
- Misses       1633   12616     10983     
  Partials      579       0      -579

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeolson lukeolson mentioned this pull request Jul 25, 2024
Open
jakirkham
jakirkham reviewed Jul 26, 2024
View reviewed changes
Copy link

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke! 🙏

These are nice improvements. Hope you find them useful 🙂

Had a couple suggestions below. Please let me know what you think

pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukeolson @jakirkham