Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper rounding of the x/y values #305

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

ladc
Copy link
Contributor

@ladc ladc commented Aug 28, 2022

Use numpy.round instead of casting to int. See issue #297

Example fix for the ERAD 2022 nowcasting workshop

Use numpy.round instead of casting to int. See issue pySTEPS#297
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #305 (cbc9911) into master (94a11b3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #305    /-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         160      160           
  Lines       12292    12292           
=======================================
  Hits        10167    10167           
  Misses       2125     2125           
Flag Coverage Δ
unit_tests 82.71% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pysteps/feature/tstorm.py 94.40% <100.00%> (ø)
pysteps/tracking/tdating.py 91.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ladc ladc requested a review from dnerini August 28, 2022 14:02
@aperezhortal aperezhortal merged commit 8c378d9 into pySTEPS:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants