Fix future warning #301
Fix future warning #301
Conversation
|
The pull request is not describing the issue it is trying to solve. |
|
Scikit image raises a future warning when using the keyword "selem" in the h_maxima function. This has been replaced with "footprint", which is the new name for this keyword. |
Codecov ReportBase: 82.71% // Head: 82.71% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #301 /- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 160 160
Lines 12292 12292
=======================================
Hits 10167 10167
Misses 2125 2125
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Very nice, thanks a lot @feldmann-m !
One small detail: the new argument name won't work for scikit-image < 0.19, therefore I suggest that you specify this minimum version in the documentation:
in the file pysteps/doc/source/user_guide/install_pysteps.rst
please specify scikit-image >= 0.19
... and not for scipy
fixed future warning from scikit-image