Option to turn off systemd plugin #3425
Conversation
|
Perhaps here https://github.com/puma/puma/blob/master/docs/deployment.md#ubuntu--systemd-systemctl-installation would be a better place to note how to disable systemd integration? |
I can't come up with a better place than systemd.md. If I search the Puma README for "systemd", I end up in the Deployment section which links to that doc. So that should be the place IMHO. |
That also just links to systemd.md |
|
Documentation updated! |
[ci skip]
test/test_skip_systemd.rb
Outdated
|
|
||
| super | ||
|
|
||
| ENV["PUMA_SKIP_SYSTEMD"] = "true" |
There was a problem hiding this comment.
This needs to be set only for this test, see the many CI failures
There was a problem hiding this comment.
ah shit, how do I do that? Not too well versed in Ruby testing I'm afraid, I thought this was the definition just for this test😅 And when i run the tests locally with rake test, the same amount of tests seem to pass as did on my local machine before I made the changes so I thought I was good, sorry about the CI failures!
There was a problem hiding this comment.
Ah maybe i un-set it in the teardown method?
There was a problem hiding this comment.
And if so, perhaps for the ENV['NOTIFY_SOCKET'] as well? Is that even a necessary line considering line 28 below? The situation in test_plugin_systemd_jruby.rb is exactly the same as well
There was a problem hiding this comment.
Ok I ended up just removing the ENV[...] lines altogether, since they seem to be set below in the env argument to cli_server below, lets see what CI says... sorry i'm not developing on a Linux machine so these tests get skipped for me
|
So looking at the failing tests, I'm seeing things like:
Should I attempt to renew those here, or is that best taken care of in another PR? |
|
That's sounds like something for another PR, I'll see if I can have a look at it |
Opened #3426 |
Merged now |
Closes #3424
Your checklist for this pull request
I have reviewed the guidelines for contributing to this repository.
I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
My pull request is 100 lines added/removed or less so that it can be easily reviewed.
If this PR doesn't need tests (docs change), I added
[ci skip]to the title of the PR.If this closes any issues, I have added "Closes
#issue" to the PR description or my commit messages.I have updated the documentation accordingly.
Not certain where the best place to document this option is. Perhaps in docs/systemd.md? But that seems to mostly just talk about systemd generally which is why I hesitated. Would be happy to document wherever maintainers think is best
All new and existing tests passed, including Rubocop.