Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix define_method calls, use Symbol parameter instead of String #3293

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

MSP-Greg
Copy link
Member

Description

Recent RuboCop fails with a similar error in four places:

lib/puma/state_file.rb:63:21: C: [Correctable] Performance/StringIdentifierArgument: Use :"#{f}=" instead of "#{f}=".
      define_method "#{f}=" do |v|
                    ^^^^^^^

We've used a string parameter for define_method, but Ruby's docs show it as a symbol. Also, an interpolated symbol could be used, but it's not commonly used, and these aren't 'hot' paths.

Fixed all occurrences.

Your checklist for this pull request

  • I have reviewed the guidelines for contributing to this repository.
  • I have added (or updated) appropriate tests if this PR fixes a bug or adds a feature.
  • My pull request is 100 lines added/removed or less so that it can be easily reviewed.
  • If this PR doesn't need tests (docs change), I added [ci skip] to the title of the PR.
  • If this closes any issues, I have added "Closes #issue" to the PR description or my commit messages.
  • I have updated the documentation accordingly.
  • All new and existing tests passed, including Rubocop.

@MSP-Greg MSP-Greg merged commit 2854916 into puma:master Dec 21, 2023
62 of 64 checks passed
@MSP-Greg MSP-Greg deleted the 00-fix-define-method branch December 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants