Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--idle-timeout should not shut down entire cluster if any single worker is idle #3282

Closed
bensheldon opened this issue Nov 26, 2023 · 1 comment · Fixed by #3283
Closed

--idle-timeout should not shut down entire cluster if any single worker is idle #3282

bensheldon opened this issue Nov 26, 2023 · 1 comment · Fixed by #3283
Labels
bug

Comments

@bensheldon
Copy link

Describe the bug

#3235 was introduced to fix #3228, but now it will shut down the entire cluster if any single worker is idle. This is currently unreleased but staged in v6.4.1.

For example, bundle exec puma -C config/puma.rb -w 10 --idle-timeout 10 seems like if the server gets 1 request every 5 seconds (less than the 10 second idle timeout), it will still shutdown. That doesn't seem right.

Expected behavior

I would expect that the idle-timeout is applied to the entire cluster. So any request to the cluster as a whole would reset the idle timer.
@bensheldon bensheldon mentioned this issue Nov 26, 2023
Merged
7 tasks
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
705443e 
…mode
@joshuay03 joshuay03 mentioned this issue Nov 28, 2023
Merged
7 tasks
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
f2af69e 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
d7e69fa 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
fa8ecc5 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
cc2394e 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
8d5a93c 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
777570c 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
238a792 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
d32eb90 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
0ad05da 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
a90cfec 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
42782dc 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
0b11e3e 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
c25e4a8 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
61b5160 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
6bede5c 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 28, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
b8ca362 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 29, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
a6fcc5d 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 29, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
f3a24dd 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 29, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
264ecf8 
…mode
@joshuay03
Copy link
Contributor

Got this up: #3283

joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 30, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
d0e4227 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 30, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
df23fbf 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 30, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
0749bd7 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 30, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
e90fe64 
…mode
joshuay03 added a commit to joshuay03/puma that referenced this issue Nov 30, 2023
@joshuay03
[Fix puma#3282] idle-timeout not waiting on all workers in cluster …
2bd0b49 
…mode
nateberkopec pushed a commit that referenced this issue Jan 2, 2024
@joshuay03
[Fix #3282] idle-timeout not waiting on all workers in cluster mode (…
f70bebd 
…#3283)
nateberkopec pushed a commit that referenced this issue Jan 2, 2024
@joshuay03 @nateberkopec
[Fix #3282] idle-timeout not waiting on all workers in cluster mode (…
a2aa800 
…#3283)
nateberkopec pushed a commit that referenced this issue Jan 2, 2024
@joshuay03 @nateberkopec
[Fix #3282] idle-timeout not waiting on all workers in cluster mode (…
09250b8 
…#3283)
nateberkopec pushed a commit that referenced this issue Jan 2, 2024
@joshuay03 @nateberkopec
[Fix #3282] idle-timeout not waiting on all workers in cluster mode (…
7e17826 
…#3283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #3282] idle-timeout not waiting on all workers in cluster mode joshuay03/puma
3 participants
@bensheldon @nateberkopec @joshuay03