Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Plotting with unbuilt model #570

Merged
merged 12 commits into from
Nov 30, 2023
Merged

Conversation

jgranley
Copy link
Member

Closes #566

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

@jgranley jgranley changed the base branch from master to cortex October 23, 2023 22:02
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (cortex@47db816). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff            @@
##             cortex     #570    /-   ##
=========================================
  Coverage          ?   93.29%           
=========================================
  Files             ?      121           
  Lines             ?    10484           
  Branches          ?        0           
=========================================
  Hits              ?     9781           
  Misses            ?      703           
  Partials          ?        0           
Flag Coverage Δ
unittests 93.29% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgranley jgranley merged commit 3979727 into pulse2percept:cortex Nov 30, 2023
19 checks passed
@jgranley jgranley mentioned this pull request Jan 13, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cortex model plotting fails if model isn't built
1 participant