feat(compliance): New AWS Performance Pillar Framework #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfagoagas
changed the title
sergargar
requested changes
Dec 11, 2023
There was a problem hiding this comment.
thanks for you PR! here’s my first review:
- the metadata for the check
ec2_instance_type_optimizedis missing (https://docs.prowler.cloud/en/latest/developer-guide/checks/#check-metadata) - the logic of
serverless_architecturein the Lambda Service is needed - the logic of
is_instance_type_optimizedin the EC2 Service is needed - please, restore the changes in the
banner.pyfile
Let me know if you need help with any of this points 😄
sergargar
requested changes
Dec 12, 2023
There was a problem hiding this comment.
I’ve just fix a typo in the name of your metadata file. Please, do the following changes:
- revert the changes done on the
awslambda_function_not_publicly_accessiblecheck - the logic of
serverless_architecturein the Lambda Service is needed - the logic of
is_instance_type_optimizedin the EC2 Service is needed
We can have a quick call if you need help 🙂
sergargar
force-pushed
the
performance_pillar_framework
branch
from
28f1764
to
bce1f02
Compare
sergargar
force-pushed
the
performance_pillar_framework
branch
from
bce1f02
to
44c0417
Compare
|
Hi @akshat-crypto , do you need help on adding the needed logic in the services? |
2 tasks
|
Hello @akshat-crypto we will close this PR. We have created this issue #4638 to keep track of the AWS Performance Pillar Framework implementation. We will use the work you did which is fantastic to complete the missing code from the review that @sergargar did. Thank you for contributing with Prowler! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To add a new customized pillar in AWS Well Architected Framework
Description
There are almost 6 AWS Well Architected Review Pillars we can use , I am currently adding Performance Pillar to test how this will work, and based on the review, we can create multiple custom checks