Revert "Chunked remote read: close the querier earlier" #14515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Believed to trigger segmentation faults due to memory-mapped block data still being accessed by iterators after the querier is closed. Signed-off-by: Bryan Boreham <[email protected]>
bboreham
force-pushed
the
revert-13777-remoteread2
branch
from
c89d10f
to
6e89250
Compare
|
I'll backport this into 2.53 (locally) and run it over to weekend to see if this fixes the crashes |
|
Haven't seen any crashes in >2d |
roidelapluie
approved these changes
Jul 29, 2024
|
Thanks |
|
SEGV code of |
bboreham
added a commit
that referenced
this pull request
Jul 29, 2024
Revert "Chunked remote read: close the querier earlier"
bboreham
added a commit
that referenced
this pull request
Jul 29, 2024
Revert "Chunked remote read: close the querier earlier"
This was referenced Jul 29, 2024
Merged
bboreham
added a commit
that referenced
this pull request
Jul 29, 2024
Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <[email protected]>
bboreham
added a commit
that referenced
this pull request
Jul 29, 2024
Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <[email protected]>
bboreham
added a commit
that referenced
this pull request
Jul 30, 2024
…14524) Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <[email protected]>
bboreham
added a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: Bryan Boreham <[email protected]>
bboreham
added a commit
that referenced
this pull request
Jul 31, 2024
…14523) Revert "Chunked remote read: close the querier earlier" Signed-off-by: Bryan Boreham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #13777
Fixes #14422
I believe the iterators for the querier can access memory-mapped files, which are closed when the querier is closed.
A better fix might be to reference-count the chunk-reader so it is only closed when no longer accessed.
cc @roidelapluie