Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsdb/index: Fix number of series in TestReader_PostingsForLabelMatchingHonorsContextCancel #14199

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Jun 3, 2024

Fix number of series in TestReader_PostingsForLabelMatchingHonorsContextCancel, as due to a refactoring mistake they become 999 instead of 1000.

I made the mistake when refactoring in #14071. As you can tell from that diff, the operator <= became <. It makes no practical difference, but is logically off :)

Fix number of series in
TestReader_PostingsForLabelMatchingHonorsContextCancel (off by one).

Signed-off-by: Arve Knudsen <[email protected]>
Copy link
Collaborator

@machine424 machine424 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly how backdoor building commits look like haha

@aknuds1 aknuds1 merged commit 31a74dc into prometheus:main Jun 3, 2024
25 checks passed
@aknuds1 aknuds1 deleted the arve/fix-test branch June 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants