Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily limit kernel command line length in Stage0 measurements #4983

Merged

Conversation

kevinloughlin
Copy link
Contributor

@kevinloughlin kevinloughlin commented Apr 4, 2024

As a temporary workaround for #4981, limit the kernel command line included in the Stage0 DICE measurements to 256 chars.

As a temporary workaround for project-oak#4981, limit the kernel command line
included in the Stage0 DICE measurements to 256 chars (1024 bytes).
Since the temporary workaround for project-oak#4981 truncates length command lines
to 256 characters, fail verification for any command lines >= 256
(characters since it may have been truncated), unless the reference
value is set to Skip.
stage0/src/lib.rs Outdated Show resolved Hide resolved
@kevinloughlin kevinloughlin enabled auto-merge (squash) April 5, 2024 16:44
@kevinloughlin kevinloughlin merged commit 0869b75 into project-oak:main Apr 5, 2024
24 checks passed
@kevinloughlin kevinloughlin deleted the tmp_cmdline_len_workaround branch April 7, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants