You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
/// The effective length of the body, excluding any padding contained
publength:u64,
}
I think the logic should be extracted to just be about serializing an arbitrary byte array so that it has a constant size. Also the current implementation uses the same object to represent both a padded and unpadded response (since this is done by calling the pad method, not in the constructor). This seems error prone from a type safety point of view, since forgetting to pad the content would not be noticeable at the type level.
The text was updated successfully, but these errors were encountered:
tiziano88
added a commit
to tiziano88/oak
that referenced
this issue
Oct 5, 2022
Currently this logic is implemented as part of a Response message, which includes a status code
oak/oak_functions/abi/src/lib.rs
Lines 41 to 48 in 52f997d
I think the logic should be extracted to just be about serializing an arbitrary byte array so that it has a constant size. Also the current implementation uses the same object to represent both a padded and unpadded response (since this is done by calling the pad method, not in the constructor). This seems error prone from a type safety point of view, since forgetting to pad the content would not be noticeable at the type level.
The text was updated successfully, but these errors were encountered: