Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify convert.js and finish standardizing parameters #7183

Merged
merged 4 commits into from
Aug 17, 2024
Merged

Modify convert.js and finish standardizing parameters #7183

merged 4 commits into from
Aug 17, 2024

Conversation

sproutleaf
Copy link

@sproutleaf sproutleaf commented Aug 17, 2024 •
edited
Loading

Addresses #7178

Changes:

A follow-up of #7179: fix parameters that weren't caught while standardizing last time.

Also modified convert.js that generates parameterData.json:

  • Removed fields that are not used in schema generation (class, name, module etc)
  • Replaced optional field with a trailing ? if parameter is optional
  • Flattened the data structure to reduce complexity and improve readability

Screenshots of the change:

Screenshot 2024-08-17 at 12 26 33 PM

PR Checklist

@sproutleaf sproutleaf self-assigned this Aug 17, 2024
@limzykenneth limzykenneth merged commit ce5f03a into processing:dev-2.0 Aug 17, 2024
0 of 2 checks passed
@sproutleaf sproutleaf changed the title Fix missing parameter standardization Modify convert.js and finish standardizing parameters Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davepagurek davepagurek Awaiting requested review from davepagurek

@limzykenneth limzykenneth Awaiting requested review from limzykenneth

Assignees

@sproutleaf sproutleaf

Labels
Friendly Errors
Projects
p5.js 2.0: FES
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sproutleaf @limzykenneth