Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : removed parent div from check box element #7164

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix : removed parent div from check box element #7164

wants to merge 3 commits into from

Conversation

Forchapeatl
Copy link
Contributor

@Forchapeatl Forchapeatl commented Aug 8, 2024 •
edited
Loading

Before

image

After

image

Resolves #5422

Changes:

Screenshots of the change:

PR Checklist

@Forchapeatl Forchapeatl marked this pull request as ready for review August 11, 2024 06:34
@Forchapeatl Forchapeatl changed the title removed parent div from check box element Fix : removed parent div from check box element Aug 11, 2024
@Forchapeatl
Copy link
Contributor Author

@limzykenneth , please for a review.

@limzykenneth
Copy link
Member

Hi @Forchapeatl, we are currently tied up on some other work related to the 2.0 version of p5.js but we'll review this in a couple week's time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

createCheckbox() without label inserts unnecessary <div>
2 participants
@Forchapeatl @limzykenneth