Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FES: Handle multiple nearest matches for a misspelt symbol #4719

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

akshay-99
Copy link
Member

@akshay-99 akshay-99 commented Jul 29, 2020

Addresses #4637

Changes:

Modify misspelling detection to handle edge cases where the typed symbol closely matches ( is the same distance away from ) two or more p5 functions/members.
For example, some misspelt symbol like stoke could match both stroke ( the function ) and STROKE ( the constant ). Earlier it would only suggest one. Now it will suggest both as

🌸 p5.js says: It seems that you may have accidently written "stoke" (on line 3 in sketch.js [http://localhost:8000/lib/empty-example/sketch.js:3:3]).

You may have meant one of the following:

▶️ STROKE (http://p5js.org/reference/#/p5/STROKE)
▶️ stroke() (http://p5js.org/reference/#/p5/stroke)

PR Checklist

Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Love the easy reference link additions and the added unit tests.

@stalgiag stalgiag merged commit 3d3e6bb into processing:main Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants