Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erase() #4646

Closed
Hickory-Kay opened this issue Jun 19, 2020 · 5 comments · Fixed by #4660
Closed

erase() #4646

Hickory-Kay opened this issue Jun 19, 2020 · 5 comments · Fixed by #4660

Comments

@Hickory-Kay
Copy link

In the reference for erase() it says that it will not erase any background() drawings, but it is erasing my background. Any help or suggestions are appreciated

@welcome
Copy link

welcome bot commented Jun 19, 2020

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@limzykenneth
Copy link
Member

In the reference it says that

Drawing done with image() and background() will not be affected by erase()

What this means is that using image() or background() in between erase() and noErase() will not make them an erasing mask, they will draw the image or background as usual. background() will be erased as erase() will remove any pixels, revealing the underlying HTML behind the canvas.

Perhaps the documentation needs to be clarified a bit regarding this.

@stalgiag
Copy link
Contributor

stalgiag commented Jun 21, 2020

Perhaps this:

Drawing done with image() and background() will not be affected by erase()

can be changed to this:

Drawing done with image() and background() will not erase.

?

@limzykenneth
Copy link
Member

@stalgiag That still feels can be potentially misunderstood. Maybe expand a bit with

Drawing done with image() and background() in between erase() and noErase() will not erase the canvas but works as usual.

@stalgiag
Copy link
Contributor

Sounds good to me @limzykenneth ! @Hickory-Kay any interest in contributing an update to the documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants