-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional parameter to orbitControl to enable/disable inverted vertical rotation #2962
Comments
how about adding two parameters |
I like the approach. Would 1 be considered the maximum allowed sensitivity so it ranges from -1 to 1 or is it just an agreed upon starting point? |
Thanks @dekmm! @AidanNelson is one of our Google Summer of Code students for p5.js and part of his project is improving the camera API and interactions for Web GL mode. Is it ok with you if I assign this issue to him? |
I don't see the need for a setting a maximum. If someone wants to make it more sensitive than normal, it should probably allow that. |
@kjhollen go ahead! |
Two questions:
|
|
closing because the fix for this has been merged into webgl-gsoc-2018! |
Nature of issue?
Most appropriate sub-area of p5.js?
Feature enhancement details:
As mentioned in PR #2956 I was thinking of adding an additional parameter to orbitControl to enable/disable inverted vertical rotation. The linked PR currently changes the inverted rotation in orbitControl, that was supposedly incorrect, to normal rotation. Knowing some users actually prefer inverted vertical rotation, adding a flag to control this would be helpful.
The text was updated successfully, but these errors were encountered: