test(client): vitess fk #22209
Draft
test(client): vitess fk #22209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
millsp
commented
Dec 2, 2023
| @@ -157,6 157,15 @@ async function main(): Promise<number | void> { | |||
| } | |||
| } | |||
|
|
|||
| if (providerFlavors.includes(ProviderFlavors.VITESS_FK)) { | |||
| jestCli = jestCli.withArgs(['--runInBand']) | |||
| // jestCli = jestCli.withEnv({ TEST_REUSE_DATABASE: 'true' }) | |||
There was a problem hiding this comment.
Migrate has some trouble to drop tables that have foreign keys in some cases, so for now each database is independent. Also, even then running in band is required as vitess has trouble in parallel mode.
janpio
reviewed
Dec 2, 2023
…prisma/_schema.ts
janpio
reviewed
Dec 3, 2023
| KEYSPACES: 'test-0000-00000000' # unused in testing, but required by vttestserver | ||
| NUM_SHARDS: '1' # unused in testing, but required by vttestserver | ||
| MYSQL_BIND_HOST: '0.0.0.0' | ||
| # FOREIGN_KEY_MODE: 'disallow' |
There was a problem hiding this comment.
Suggested change
| # FOREIGN_KEY_MODE: 'disallow' |
janpio
reviewed
Dec 3, 2023
Comment on lines
105
to
106
| KEYSPACES: 'test-0000-00000000' # unused in testing, but required by vttestserver | ||
| NUM_SHARDS: '1' # unused in testing, but required by vttestserver |
There was a problem hiding this comment.
Suggested change
| KEYSPACES: 'test-0000-00000000' # unused in testing, but required by vttestserver | |
| NUM_SHARDS: '1' # unused in testing, but required by vttestserver | |
| KEYSPACES: 'test-0000-00000000' | |
| NUM_SHARDS: '1' |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see the setup changes only)
#22276 builds on this