#1702 feat(registry): integrate google container registry #1755
Conversation
There was a problem hiding this comment.
Thanks for the contribution @rahulruikar and sorry for the delay.
Just did a functional review, here are the things I think are missing:
-
Title of the option should be: GCR
-
Description of the option (subtext) should have capitalized letters: Google Container Registry
-
The GCR option should be the second option right after Quay.io
-
When choosing GCR, a section called "Information" should appear (similar to "Important notice" when using Custom registry) with the following text:
Follow the <official instructions> (link to https://cloud.google.com/container-registry/docs/advanced-authentication#using_a_json_key_file) to generate the credentials from a service account JSON key file.
-
Instead of showing the Name and Registry URL fields, a field called Project identifier should be available. It should be used to build the Name & Registry URL fields.
-
The Username field should be disabled as it should not take another value than
_json_key.
|
ping @rahulruikar |
deviantony
added
status/stale
status/1-functional-review
|
@rahulruikar are you still up to do the changes? |
|
Hi Anthony,
I won’t be able to spend time on this anytime soon.
Regards
Rahul
On Wed, 19 Sep 2018 at 1:24 pm, Anthony Lapenna ***@***.***> wrote:
@rahulruikar <https://github.com/rahulruikar> are you still up to do the
changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1755 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHXNPfQ32PMyfjuQRHi6Hlpv2bfm2clDks5ucbjmgaJpZM4S3FRE>
.
--
Sent from Gmail Mobile
|
|
No problem @rahulruikar, thanks for the update. |
attempt to integrate google container registry as per instructions given in this enhancement request.
#1702