Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Clear cache folder after closing the App?" checkbox does not work #3026

Closed
refaelsh opened this issue Jul 27, 2024 · 6 comments
Closed

The "Clear cache folder after closing the App?" checkbox does not work #3026

refaelsh opened this issue Jul 27, 2024 · 6 comments
Labels
bug

Comments

@refaelsh
Copy link

Operating System Version: NixOS

Popcorn Time Version:

0.5.1

Download date:

Approximately on 23/07/2024

Download url:

I used the NixOS package.

Expected Behavior:

I expected the cache folder not to be cleared when the checkbox is unchecked.

Actual Behavior:

The cache folder is always cleared no matter if the checkbox is checked or not.

Steps to reproduce the behavior:

  1. Uncheck the checkbox.
  2. Download a movie.
  3. Close the app.
  4. Open the app - the movie is gone from the cache folder.
@merseyV
Copy link

merseyV commented Jul 27, 2024

From your previous post/issue.

It is unchecked. Hmm...

Just curious: Did you mean (by that) the option was already unticked (default setting wasn't applied) ... or you had already unticked it yourself, manually?

@refaelsh refaelsh mentioned this issue Jul 28, 2024
Closed
@refaelsh
Copy link
Author

From your previous post/issue.

It is unchecked. Hmm...

Just curious: Did you mean (by that) the option was already unticked (default setting wasn't applied) ... or you had already unticked it yourself, manually?

I dont really remember what was the default state.

@dutchy1001
Copy link
Collaborator

Default state is that it clears the cache folder.
This only will be reset when doing a clean install, if only updating to newer version it will keep the settings that have been set before.

@dutchy1001
Copy link
Collaborator

Just re-tested this on a windows 11 pc but all working as it should. When ticked the cache is emptied (deleted) and when unticked all files are still there.

If this is still an issue plz comment (so I can add a "bug" label) or close it

@refaelsh
Copy link
Author

If this is still an issue plz comment (so I can add a "bug" label) or close it

Its still an issue, yes.

@dutchy1001 dutchy1001 added the bug label Aug 16, 2024
@refaelsh
Copy link
Author

@kiriles90 I am extremely curious to what fixes that. Is there a PR I can look at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@refaelsh @dutchy1001 @kiriles90 @merseyV