Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build system for the Apple Silicon macOS build #2762

Open
Agusum opened this issue Aug 4, 2023 · 13 comments
Open

Fix the build system for the Apple Silicon macOS build #2762

Agusum opened this issue Aug 4, 2023 · 13 comments

Comments

@Agusum
Copy link

Agusum commented Aug 4, 2023

Now that NW.js supports Apple Silicon, it would be great if Popcorn Time could have a macOS universal build.

@TongDaDa
Copy link

TongDaDa commented Aug 7, 2023

Now, there has two builds, osx64 & arm64, and haven't the universal build, may be supported in the future after the chromium and nodejs release the same.

@Agusum
Copy link
Author

Agusum commented Nov 13, 2023

Hi, has there been any progress on this task?

@JohnnyFireOne
Copy link

I'm totally into this!!!!!!!! fingers crossed!

@kiriles90 kiriles90 changed the title Universal macOS build for Apple Silicon Fix the build system for the macOS build for Apple Silicon Feb 13, 2024
@kiriles90
Copy link
Collaborator

kiriles90 commented Feb 13, 2024

So.. the way the macOS arm64 build was included in the release of version 0.5.0 was by basically tricking our workflows/build system to think that it was building the x64 one (renaming the NW.js sdk, yes I know..) then manually attaching the output to the release.

Obviously this cannot remain like this so changing the title to fit the issue and tagging this as a bug (even if its with the build system and our current junky solution produces the exact same .zip & .pkg's). Hopefully someone can help fix the build files, gulpfile etc to process this the same way they do with everything else. (also no arm64 build for NW.js 0.44.5 so any solution will have to take that into account too)

P.s the current NW.js 0.82.0 location that's in the gulpfile includes the arm64 sdk, also patched with the ffmpeg prebuild libraries like the rest of the sdks there so that's good to go.

@merseyV
Copy link

merseyV commented Feb 13, 2024

And "xattr -cr /path/to/application.app" before you open .. for now?

Edit: or as I've since found ... use a Download Manager (doesn't add flags to .zip file).

@AlirezaXdehghan
Copy link

fix the build files, gulpfile etc to process this the same way they do with everything else. (also no arm64 build for NW.js 0.44.5 so any solution will have to take that into account too)

I went down the rabbit hole, so the version of the nw-builder that is associated to this build, cannot detect arm64 macs, it detects them as osx32 and that doesn't build because nwbuilder defaults to v0.82.0, not taking the osx32 into account, that's easy to do, a simple change in the gulp file to fix the build for osx32.

the bigger problem is that, nwbuilder 3.7.4 does not even recognize arm64 as a platform, here's the old one's page
so we have to use a newer version of nwbuilder which creates another problem, imports are different for whatever reason, I don't do js so idk, but nwbuilder has changed a lot so gulp file might need to be rewritten almost from the ground up wherever we interact with nwbuilder.

@kiriles90 kiriles90 changed the title Fix the build system for the macOS build for Apple Silicon Fix the build system for the Apple Silicon macOS build Feb 16, 2024
@Scott16546
Copy link

Screenshot 2024-04-21 at 18 46 56
never had this on m1 before the update

@merseyV
Copy link

merseyV commented Apr 22, 2024

never had this on m1 before the update

You must have been using the non-arm64 version before? Both Popcorntime 0.5.0 and 0.5.1 (Silicon) versions show that warning notice?

A Silicon app package has to be signed/notarised (using an Apple developer account), or it throws a flag when it downloads .. and Gatekeeper won't pass it. It shows this "warning" notice to deter users from using unsigned apps.

Just strip the quarantine flag/s .. if you want to continue?

@chengsokdara
Copy link

chengsokdara commented Apr 23, 2024

never had this on m1 before the update

run this in terminal to remove the quarantine flag
xattr -c <path/to/Popcorn-Time.app>

example:
xattr -c /Applications/Popcorn-Time.app

@Scott16546
Copy link

Screenshot 2024-04-23 at 16 30 09

@merseyV
Copy link

merseyV commented Apr 23, 2024

Don't put "/path/to/application.app" into Terminal: It's just a way of saying - put the path to the popcorntime app (it's location?)

Just put a space after xattr -c and drag the PTapp into the Terminal window .. to insert its location?

@Scott16546
Copy link

Screenshot 2024-06-16 at 14 46 46

@merseyV
Copy link

merseyV commented Jun 16, 2024

Terminal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

8 participants