Add a OSS mixer module. #3130
Open
Add a OSS mixer module. #3130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based mosty on the ALSA module, but with a few caveats: - No headphone support (OSS sees a separate soundcard) - No equivalent to mapped (yet) Drop pseudo-mute, newer-ish OSS implementation should provide mute. Use soundcard name from SOUND_MIXER_INFO if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Hi, I just began a few weeks ago to use polybar on freebsd and love it. Something I am missing would be a mixer module for freebsd base sound api, OSS (which can be used on other systems), so I had a look to write one and wondered if you would be interested in accepting such module.
My code is based mostly on the ALSA module, but with a few caveats:
I found that this module will build on Linux without any specific dependency (tested on debian, soundcard.h provided by linux-libc-dev), but would not recommend to run it even for a testsuite there as ALSA OSS compat layer has been described as broken forever.
Given I mostly based it on the ALSA module, I hope it will meet the project coding conventions and best practices.
I realize this code will not interest that many people, but one good thing with OSS is that it doesn't change a bit, I'd expect this code to be a burden only in the case of a polybar refactoring.
Thanks for your work and reviewing this request.
Related Issues & Documents
No issue related
Documentation (check all applicable)
This change should go with a new wiki page, for which the ALSA module doc can be a start with only a few changes (device, mixer fields, removing headphone/mapped entries). I'll write this if the project express interest in going forward integrating this module.